-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement FromRequest for BytesMut #2583
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mladedav
reviewed
Feb 10, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jplatte
force-pushed
the
jplatte/bytes-from-request
branch
from
February 11, 2024 10:54
80d84e6
to
1a43af4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This change seems to be sufficient to handle limits on body size: #2592 |
Thanks! |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jplatte
force-pushed
the
jplatte/bytes-from-request
branch
from
February 22, 2024 20:39
94f545f
to
3d32d0f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jplatte
force-pushed
the
jplatte/bytes-from-request
branch
from
February 22, 2024 20:41
3d32d0f
to
ab2b9e7
Compare
jplatte
changed the title
WIP: Optimize FromRequest for Bytes
Optimize FromRequest for Bytes
Feb 22, 2024
mladedav
reviewed
Feb 22, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jplatte
changed the title
Optimize FromRequest for Bytes
Implement FromRequest for BytesMut
Jun 14, 2024
Co-authored-by: Yann Simon <[email protected]>
jplatte
force-pushed
the
jplatte/bytes-from-request
branch
from
September 11, 2024 19:25
4493713
to
5be2509
Compare
jplatte
force-pushed
the
jplatte/bytes-from-request
branch
from
September 11, 2024 19:51
af15d08
to
5be2509
Compare
seanmonstar
approved these changes
Sep 20, 2024
jplatte
added a commit
that referenced
this pull request
Sep 20, 2024
Co-authored-by: Yann Simon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2548.